Fold target help into the help system. #11022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
Instead of it being the only help-related functionality implemented as a standalone goal. Also replaces `./pants goals` with `./pants help goals`, and makes various other improvements to help, such as not showing global option help when you just enter `./pants help`, so that the usage message fits in a single screen. Addresses pantsbuild#10999. [ci skip-rust] [ci skip-build-wheels]
|
|
Eric-Arellano
approved these changes
Oct 22, 2020
| print(f"\nPants {pants_version()}") | ||
| print("\nUsage:\n") | ||
| print_cmd( | ||
| "[option ...] [goal ...] [file/target ...]", |
There was a problem hiding this comment.
You can also add options after the specs, which is often much more convenient.
Suggested change
| "[option ...] [goal ...] [file/target ...]", | |
| "[option ...] [goal ...] [file/target ...] [option ...]", |
There was a problem hiding this comment.
Yeah, but only if there are specs, I think. Otherwise the options will be bound to the goal scope, which gets complicated to explain.
There was a problem hiding this comment.
Yeah, that's correct.
gshuflin
reviewed
Oct 22, 2020
Eric-Arellano
pushed a commit
to Eric-Arellano/pants
that referenced
this pull request
Oct 22, 2020
[ci skip-rust] [ci skip-build-wheels] # Conflicts: # src/python/pants/bin/local_pants_runner.py
Eric-Arellano
added a commit
that referenced
this pull request
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of it being the only help-related functionality
implemented as a standalone goal.
Also replaces
./pants goalswith./pants help goals,and makes various other improvements to help, such as
not showing global option help when you just enter
./pants help, so that the usage message fits in asingle screen.
Addresses #10999.
[ci skip-rust]
[ci skip-build-wheels]