Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup_py().with_binaries() to use the default entry point (Cherry-pick of #11021) #11026

Merged
merged 1 commit into from Oct 22, 2020

Conversation

Eric-Arellano
Copy link
Contributor

[ci skip-rust]
[ci skip-build-wheels]

…sbuild#11021)

There was no particular reason we required `entry_point` to be set.

[ci skip-rust]
[ci skip-build-wheels]
Copy link
Contributor Author

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cherry-pick with no meaningful modifications (there was a small merge conflict in the tests.)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 89e68d6 on Eric-Arellano:cp-with-b into a6e1151 on pantsbuild:2.0.x.

@Eric-Arellano Eric-Arellano merged commit 49e9987 into pantsbuild:2.0.x Oct 22, 2020
@Eric-Arellano Eric-Arellano deleted the cp-with-b branch October 22, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants