remote caching: upload stdout/stderr content to remote cache #11049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-build-wheels]
Eric-Arellano
approved these changes
Oct 26, 2020
| &self, | ||
| command: &Command, | ||
| result: &FallibleProcessResultWithPlatform, | ||
| store: &Store, | ||
| ) -> Result<ActionResult, String> { | ||
| ) -> Result<(ActionResult, Vec<Digest>), String> { | ||
| // Keep track of digests that need to be uploaded. |
There was a problem hiding this comment.
Perhaps add a comment explaining that this may contain both File Digests and Directory Digests. (If those are the correct terms). I could see that not being immediately obvious. Perhaps have that in the docstring to describe the return type.
There was a problem hiding this comment.
Done. It actually includes Tree digests and not Directory digests.
[ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci skip-build-wheels]
Problem
With remote caching enabled, stdout and stderr outputs were not uploaded to the remote cache.
Solution
Teach
make_action_resultto include the digests for stdout and stderr content in the list of digests to upload.make_action_resultnow returns that list of digests so it can be verified in a unit test.Result
Added unit test.