Deprecate the platforms field allowing a bare string
#11073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
approved these changes
Oct 28, 2020
Comment on lines
+197
to
+198
| if isinstance(raw_value, str) and address.is_base_target: | ||
| warn_or_error( |
There was a problem hiding this comment.
Nit: the if+warn_or_error combo is what deprecated_conditional is meant to accomplish. It doesn't really have a great advantage over this usage, other than that it's a bit more obvious that the conditional/if exists only to serve the deprecation.
There was a problem hiding this comment.
Oh, true. I'll fix in a related followup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringOrStringSequenceFieldis a misfeature. It's confusing, and only saves 2 characters between["foo"]vs."foo".We'll remove the only remaining instance, the
compatiblityfield, as part of #9273.[ci skip-rust]
[ci skip-build-wheels]