Add ./pants py-constraints --summary for project overview
#11099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-rust] [ci skip-build-wheels]
|
fyi @rcuza - feedback welcomes. Blog post about Py2 -> Py3 support coming soon :) |
stuhood
approved these changes
Nov 6, 2020
src/python/pants/backend/python/mixed_interpreter_constraints/py_constraints.py
Show resolved
Hide resolved
src/python/pants/backend/python/mixed_interpreter_constraints/py_constraints.py
Outdated
Show resolved
Hide resolved
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
rcuza
reviewed
Nov 6, 2020
There was a problem hiding this comment.
This is great. I think the CSV output is a great way of avoiding the UX overflow this amount of data would produce.
I offer some suggestions on how to improve the wording to users. Not sure if they are better or worse than the original wording. Use or ignore as you see fit.
src/python/pants/backend/python/mixed_interpreter_constraints/py_constraints.py
Outdated
Show resolved
Hide resolved
src/python/pants/backend/python/mixed_interpreter_constraints/py_constraints.py
Outdated
Show resolved
Hide resolved
Thanks Raúl! Great suggestions. Also, improve the warning of when you're not using `--summary` and have no matching targets/files. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to give an overview of the current status of your project, and to help with prioritization for things like Python 3. In contrast,
./pants py-constraintswithout--summaryis intended for debugging on the local terminal.We export as a CSV and expect users to import into Excel or Google Sheets to analyze the data. For example, https://docs.google.com/spreadsheets/d/1B_2WNmXuXCMbhU6h8nwhSV3YdArJZtE_qODYcI2968o/edit?usp=sharing.
We always run over the entire repo, rather than looking at user specs. This simplifies handling of subtargets and differences between file args vs. target args; both types of addresses are included in the analysis.
[ci skip-rust]
[ci skip-build-wheels]