Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix !! transitive excludes when used multiple times in a repo #11103

Merged
merged 2 commits into from Nov 6, 2020
Merged

Fix !! transitive excludes when used multiple times in a repo #11103

merged 2 commits into from Nov 6, 2020

Conversation

Eric-Arellano
Copy link
Contributor

@Eric-Arellano Eric-Arellano commented Nov 6, 2020 •
edited

Fixes #11101. We were unintentionally using the positional args style for MultiGet, when we meant to use the comprehension style.

[ci skip-build-wheels]
[ci skip-rust]

@Eric-Arellano
Fix !! transitive excludes when used multiple times in a repo
89bd65c 
[ci skip-build-wheels]

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]
stuhood
stuhood approved these changes Nov 6, 2020
View reviewed changes
Copy link
Sponsor Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tiny test to cover this would be great.

@Eric-Arellano Eric-Arellano mentioned this pull request Nov 6, 2020
Closed
tdyas
tdyas approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@tdyas tdyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eric-Arellano
Add a regression test
48acf01 
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 48acf01 on Eric-Arellano:fix-transitive-excludes into 72d0409 on pantsbuild:master.

@Eric-Arellano Eric-Arellano merged commit 60188ee into pantsbuild:master Nov 6, 2020
@Eric-Arellano Eric-Arellano deleted the fix-transitive-excludes branch November 6, 2020 01:16
Eric-Arellano added a commit to Eric-Arellano/pants that referenced this pull request Nov 6, 2020
@Eric-Arellano
Fix !! transitive excludes when used multiple times in a repo (pant…
bded80e 
…sbuild#11103)

Fixes pantsbuild#11101. We were unintentionally using the positional args style for `MultiGet`, when we meant to use the comprehension style.

[ci skip-build-wheels]
[ci skip-rust]
Eric-Arellano added a commit that referenced this pull request Nov 6, 2020
@Eric-Arellano
Fix !! transitive excludes when used multiple times in a repo (#11103…
2c976a0 
…) (#11104)

Fixes #11101. We were unintentionally using the positional args style for `MultiGet`, when we meant to use the comprehension style.

[ci skip-build-wheels]
[ci skip-rust]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuhood stuhood stuhood approved these changes

@tdyas tdyas tdyas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue running typecheck with ignoring transitive dependencies with !!target
4 participants
@Eric-Arellano @coveralls @stuhood @tdyas