Fix logs for test, lint, fmt, and typecheck to always print, even if cached (Cherry-pick of #11111)
#11116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…even if cached (pantsbuild#11111) Closes pantsbuild#10918. Rather than inventing some new engine mechanism like a `force_log=True` toggle—which would be costly to maintain—we leverage uncachable rules. We use a pattern where the downstream plugins return the data (e.g. `LintResults`), and then we automatically enrich it for the sake of IO (e.g. `EnrichedLintResults`). This ensures that the data computation is memoized, while the IO is forced to rerun. As we were doing before, we can augment the logging with extra info, e.g. using `--test-output` to determine what to log. ### Result Regardless of how many times you run this command, we get consistent output (modulo inconsistent ordering of logs): ``` ▶ ./pants --changed-since=HEAD~1 lint 01:26:44.10 [INFO] Completed: lint - Docformatter succeeded. 01:26:44.21 [INFO] Completed: lint - isort succeeded. 01:26:44.51 [INFO] Completed: lint - Flake8 succeeded. 01:26:44.75 [INFO] Completed: lint - Black succeeded. All done! ✨ 🍰 ✨ 8 files would be left unchanged. ``` [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
commented
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci skip-rust]