Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the sources field for python_awslambda (Cherry-pick of #11176) #11177

Merged
merged 1 commit into from Nov 13, 2020

Conversation

Eric-Arellano
Copy link
Contributor

[ci skip-rust]
[ci skip-build-wheels]

…antsbuild#11176)

[ci skip-rust]
[ci skip-build-wheels]
# Conflicts:
#	src/python/pants/backend/awslambda/python/rules_test.py
deprecated_removal_hint = (
"Because the `sources` field will be removed, it no longer makes sense to have a "
"`compatibility` field for `python_awslambda` targets. Instead, set the "
"`compatibility` field on the `python_library` target containing this lambda's "
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is originally interpreter_constraints, but that field didn't exist in 2.0 so we use compatibility.

Copy link
Contributor

@tdyas tdyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 9fab4cb on Eric-Arellano:cp-aws-20 into 71394ec on pantsbuild:2.0.x.

@Eric-Arellano Eric-Arellano merged commit 4413db5 into pantsbuild:2.0.x Nov 13, 2020
@Eric-Arellano Eric-Arellano deleted the cp-aws-20 branch November 13, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants