Set the soft ulimit value more conservatively (cherrypick of #11194) #11196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y sets a hard value of "maxint". (pantsbuild#11194) ### Problem Big Sur seemingly sets a hard ulimit value of "maxint", which results in our soft ulimit also becoming maxint. That would be fine, but some (badly behaved, imo) libraries consume the soft ulimit as a default value for their configuration. ### Solution We are fairly certain that we don't need more than 10k file handles in standard usage, so set the soft ulimit value more conservatively to `soft_limit = min(hard_limit, 10k)`. [ci skip-build-wheels]
Eric-Arellano
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Big Sur seemingly sets a hard ulimit value of "maxint", which results in our soft ulimit also becoming maxint. That would be fine, but some (badly behaved, imo) libraries consume the soft ulimit as a default value for their configuration.
Solution
We are fairly certain that we don't need more than 10k file handles in standard usage, so set the soft ulimit value more conservatively to
soft_limit = min(hard_limit, 10k).[ci skip-build-wheels]