Increase Pants' python recursion limit by default, and allow it to be overridden. (cherrypick of #11271) #11276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirois
approved these changes
Dec 8, 2020
… overridden. (pantsbuild#11271) ### Problem Pants uses a default Python recursion limit that makes some build graph shapes fail to cycle detect: see pantsbuild#11201. ### Solution Increase the default recursion limit, and allow it to be overridden via an environment variable. Although increasing the recursion limit is not always the best approach to solving a problem, having the capability to do so is frequently useful as a workaround. We also know that the default value is too low for otherwise reasonable graph shapes. ### Result Fixes pantsbuild#11201.
stuhood
force-pushed
the
stuhood/pick-11271-for-2.0.x
branch
from
3530cfa
to
081f331
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Pants uses a default Python recursion limit that makes some build graph shapes fail to cycle detect: see #11201.
Solution
Increase the default recursion limit, and allow it to be overridden via an environment variable.
Although increasing the recursion limit is not always the best approach to solving a problem, having the capability to do so is frequently useful as a workaround. We also know that the default value is too low for otherwise reasonable graph shapes.
Result
Fixes #11201.
[ci skip-rust]
[ci skip-build-wheels]