use Bytes instead of Vec<u8> for protobuf binary fields #11342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdyas
changed the title
Bytes support
tdyas
pushed a commit
that referenced
this pull request
Dec 19, 2020
### Problem Landed #11342 without updating the `prost` crate version in the `concrete_time` crate. ### Solution Update the revision to conform. ### Result Existing tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#11307 upgraded the gRPC code to Tonic from grpcio. As part of that upgrade, Pants now uses Prost to generate Rust structs for protobuf types. By default, Prost encodes binary fields as
Vec<u8>. Given the attendant problems ofVec<u8>of needing to copy around bytes when structs are cloned, the more efficient method is to useBytesfor the representation to avoid unnecessary copies.Solution
Upgrade Prost to danburkert/prost@a1cccbc and enable using
Bytesfor all binary fields.Result
Existing tests pass.