Expose --resolver-version, deprecate --cache-ttl. #11349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirois
commented
Dec 19, 2020
| @@ -12,7 +12,10 @@ class Flake8(PythonToolBase): | |||
|
|
|||
| options_scope = "flake8" | |||
| default_version = "flake8>=3.7.9,<3.9" | |||
| default_extra_requirements = ["setuptools<45"] # NB: `<45` is for Python 2 support | |||
| default_extra_requirements = [ | |||
| "setuptools<45; python_full_version == '2.7.*'", | |||
There was a problem hiding this comment.
N.B.: The pip-2020-resolver failed the LHS as insoluable for Python 3.
jsirois
commented
Dec 20, 2020
Update to the new and deprecated features of Pex 2.1.24 by exposing --resolver-version and deprecating --cache-ttl. For now we keep the pip-legacy-resolver default for --resolver-version, but encourage users migrating to the pip-2020-resolver. [ci skip-rust] [ci skip-build-wheels]
jsirois
force-pushed
the
Pex-2.1.24/plumb
branch
from
e9df645
to
c378b44
Compare
| advanced=True, | ||
| type=ResolverVersion, | ||
| default=ResolverVersion.PIP_LEGACY, | ||
| deprecation_start_version="2.3.0.dev1", |
There was a problem hiding this comment.
These can both be dev0.
There was a problem hiding this comment.
If it flakes red I'll make that switch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the new and deprecated features of Pex 2.1.24 by exposing
--resolver-version and deprecating --cache-ttl. For now we keep the
pip-legacy-resolver default for --resolver-version, but encourage users
migrating to the pip-2020-resolver.
[ci skip-rust]
[ci skip-build-wheels]