Fix older versions of tar not working when creating an archive (Cherry-pick of #11413)
#11418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…antsbuild#11413) A user reported that the builtin `tar` on macOS Mojave (2.8) was erroring because of the argv including `a`. We instead can explicitly specify the format. Note that not all formats will still work on older tar versions, e.g. 2.8 does not support the `J` flag to create `.tar.xz`. The user will need to choose a compatible `format` instead like `tar`. We do not eagerly detect this situation because there are so many implementations of `tar` - it's an open question if we should check the failed process, though, so that we can augment the error message with info on this possible gotcha? [ci skip-rust] [ci skip-build-wheels]
stuhood
approved these changes
Jan 6, 2021
[ci skip-rust] [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
This reverts commit b892663. [ci skip-rust] [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci skip-rust]
[ci skip-build-wheels]