Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failure logging to the StoreGCService. #11460

Merged

Conversation

stuhood
Copy link
Sponsor Member

@stuhood stuhood commented Jan 13, 2021

Problem

Production pantsd logs sometimes indicate that the StoreGCService has exited, which triggers a pantsd restart. But we do not have enough logging in shutdown to determine the reason for the exit.

Solution

We already have test coverage that rules out deterministic failures (and local checks confirm that the store is working as intended in common usage), so add logging to catch the unexpected cases.

[ci skip-rust]
[ci skip-build-wheels]

[ci skip-rust]

[ci skip-build-wheels]
@stuhood stuhood merged commit 183ed26 into pantsbuild:master Jan 13, 2021
@stuhood stuhood deleted the stuhood/gc-service-failure-logging branch January 13, 2021 21:19
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants