Add failure logging to the StoreGCService. #11460
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Production
pantsd
logs sometimes indicate that theStoreGCService
has exited, which triggers apantsd
restart. But we do not have enough logging in shutdown to determine the reason for the exit.Solution
We already have test coverage that rules out deterministic failures (and local checks confirm that the store is working as intended in common usage), so add logging to catch the unexpected cases.
[ci skip-rust]
[ci skip-build-wheels]