Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logging level for Scrubbed PYTHONPATH from env message + use fstrings #11480

Merged
merged 1 commit into from Jan 21, 2021

Conversation

asherf
Copy link
Member

@asherf asherf commented Jan 21, 2021

Problem

If PYTHONPATH is defined in the env, this message will show up every time pants start, which is somewhat noisy (and also probably useless)

Solution

Change log level of that message

Result

Cleaner output in pants runs.

@asherf
Copy link
Member Author

asherf commented Jan 21, 2021

@Eric-Arellano @stuhood this is somewhat opinionated, but I keep seeing this message when running pants, so at some point it is clutter. but I understand that there is a reason to have it in other use cases.
So feel free to close this PR of this change is not appropriate.

Copy link
Sponsor Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this.

Thanks!

@stuhood stuhood merged commit bebdf6d into pantsbuild:master Jan 21, 2021
@asherf asherf deleted the reqs branch January 21, 2021 17:46
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This has also bothered me for a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants