Deprecate [python-setup].resolver_version defaulting to pip legacy resolver
#11497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resolver # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
jsirois
approved these changes
Jan 25, 2021
| def resolver_version(self) -> ResolverVersion: | ||
| if self.options.is_default("resolver_version"): | ||
| warn_or_error( | ||
| removal_version="2.4.0.dev0", |
There was a problem hiding this comment.
Is this intentional? The removal is 2.5.0.dev0 per the language below. 2.4.0.dev0 is only the default flip.
There was a problem hiding this comment.
Yep, this deprecation is solely for the default. Then in 2.4, we will remove this deprecation and flip the default, and deprecate the option entirely.
There was a problem hiding this comment.
Hrm - OK. A bit unfortunate assuming the word removal shows up in help output - since that is not true. But thats the infra we have. SG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before deprecating the option entirely, we must first change the default behavior to do what we want.
[ci skip-rust]
[ci skip-build-wheels]