Add --remote-store-headers and fix --remote-execution-headers to not impact remote caching
#11501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ote cache runner This fixes the remote cache runner to no longer use --remote-execution-headers, which was a misnomer. While this is a breaking API change, its semantics were never documented and this is an alpha API.
gshuflin
reviewed
Jan 27, 2021
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
gshuflin
reviewed
Jan 27, 2021
Eric-Arellano
changed the title
--remote-store-headers--remote-store-headers (and fix --remote-execution-headers to not impact remote caching)
Eric-Arellano
changed the title
--remote-store-headers (and fix --remote-execution-headers to not impact remote caching)--remote-store-headers and fix --remote-execution-headers to not impact remote caching
gshuflin
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only had
--remote-execution-headers. We weren't applying those to the store setup, and we were incorrectly applying them to the remote cache setup.We considered instead consolidating to only have
--remote-headers, which applies to both contexts. However, prior art from Bazel shows that it's useful to have service-specific options and we avoid a deprecation warning this way. We could add both--remote-headersand--remote-store-headers, but that's not done here for simplicity. We can add--remote-headersin the future, if necessary.This PR also refactors to convert the
--remote-oauth-bearer-token-pathinto the relevant header in Python, before crossing the FFI boundary. This simplifies our Rust code so that it simply gets a dictionary of headers. All header injection now happens in Python, which will facilitate adding a plugin hook to dynamically set these headers.