Support --venv mode for pex_binary targets.
#11510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce the `execution_mode` field to `pex_binary` which accepts 'zipapp' (the default), 'unzip' and 'venv' and deprecate the `unzip` field. [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
approved these changes
Feb 2, 2021
I see no reason to make this - or any - field required if there is a sensible default, and there is. In this case its the underlying tool's (Pex's) default. I have no clue what the future default will be yet. |
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
approved these changes
Feb 4, 2021
|
Noting that I've been holding off merging this since a manual test that added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the
execution_modefield topex_binarywhich accepts'zipapp' (the default), 'unzip' and 'venv' and deprecate the
unzipfield.
[ci skip-rust]
[ci skip-build-wheels]