Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MyPy typechecking now handles Python 3.9+. #11537

Merged
merged 1 commit into from Feb 9, 2021

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Feb 9, 2021

Previously MyPy was arbitrarily restricted to working with Python 3.8
syntax and below.

[ci skip-rust]
[ci skip-build-wheels]

Previously MyPy was arbitrarily restricted to working with Python 3.8
syntax and below.

[ci skip-rust]
[ci skip-build-wheels]
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, much more elegant! Excellent!

@jsirois jsirois merged commit c4deac6 into pantsbuild:master Feb 9, 2021
@jsirois jsirois deleted the mypy/fix_constraints branch February 9, 2021 14:53
Eric-Arellano pushed a commit to Eric-Arellano/pants that referenced this pull request Feb 9, 2021
Previously MyPy was arbitrarily restricted to working with Python 3.8
syntax and below.
# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
Eric-Arellano added a commit that referenced this pull request Feb 9, 2021
Eric-Arellano added a commit that referenced this pull request Feb 9, 2021
Similar to how #11537 fixed MyPy to work with 3.9 by default, this does the same for Black.

Note that this won't actually impact most end-users - the latest release of Black does not understand PEP 614, the new decorators grammar. But this future-proofs Pants for when the new Black release comes out.

[ci skip-rust]
[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants