Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Use the toolchain plugin to auth to the remote caching API #11544

Merged
merged 1 commit into from Feb 10, 2021

Conversation

asherf
Copy link
Member

@asherf asherf commented Feb 9, 2021

DO NOT MERGE YET we will need to replace the token we are using w/ travis to one that supports the caching permissions/audience.

This seems to be working. however, I want to test it a few more times (by rebasing and pushing) to make sure this is robust.

@asherf asherf marked this pull request as draft February 9, 2021 23:15
@asherf asherf force-pushed the costanza branch 3 times, most recently from 7720e35 to 8ffefab Compare February 10, 2021 19:38
@asherf asherf changed the title WIP - try using the auth plugin for remote cache. [Internal] Use the toolchain plugin to auth to the remote caching API Feb 10, 2021
@asherf asherf marked this pull request as ready for review February 10, 2021 23:12
@asherf
Copy link
Member Author

asherf commented Feb 10, 2021

this is g2g, please review and let me know if you have any feedback.

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Asher! This looks great.

The only thing I can think of is the top of pants.remote-cache.toml is now stale. But no need to push a fix, let's save the CI time. I'll fix in a followup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants