Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove testprojects/src/python/unicode/compilation_failure. #11562

Merged
merged 1 commit into from
Feb 14, 2021

Conversation

benjyw
Copy link
Sponsor Contributor

@benjyw benjyw commented Feb 14, 2021

We prefer tests to generate their own data and clean it up, rather
than have checked in sources, deliberately broken in some cases,
to act as test input.

Now ./pants lint :: passes.

[ci skip-rust]

[ci skip-build-wheels]

Now `./pants lint ::` passes.

[ci skip-rust]

[ci skip-build-wheels]
@benjyw benjyw merged commit 652df2c into pantsbuild:master Feb 14, 2021
@benjyw benjyw deleted the remove_more_testprojects branch February 14, 2021 16:10
@Eric-Arellano Eric-Arellano mentioned this pull request Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants