Auto-discover CA certs if TLS is used and --remote-ca-certs-path is unset
#11572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te-ca-certs-path` is unset [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
changed the title
--remote-ca-certs-path is unset--remote-ca-certs-path is unset
illicitonion
approved these changes
Feb 17, 2021
[ci skip-rust] [ci skip-build-wheels]
tdyas
reviewed
Feb 18, 2021
| grpc_util::create_endpoint( | ||
| addr.as_str(), | ||
| if store_use_tls { | ||
| tls_client_config.as_ref() |
There was a problem hiding this comment.
more functional is: tls_client_config.filter(|_| store_use_tls).as_ref()
There was a problem hiding this comment.
But no need to change now that it's landed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11545. This makes it easier for folks to get set up with remote caching and execution.
Users can still set their own cert file with
--remote-ca-certs-path.By now setting up TLS based on the scheme used for
--remote-store-addressand--remote-execution-address, rather than if--remote-ca-certs-pathis set, users can now optionally use TLS for only the store or only remote execution, for example.[ci skip-rust]
[ci skip-build-wheels]