Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated --process-execution-speculation options. #11610

Merged
merged 1 commit into from
Feb 27, 2021
Merged

Remove deprecated --process-execution-speculation options. #11610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
31 changes: 0 additions & 31 deletions src/python/pants/option/global_options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,37 +764,6 @@ def register_bootstrap_options(cls, register):
"process cache entries from being (re)used for different usecases or users."
),
)
register(
"--process-execution-speculation-delay",
type=float,
default=1,
advanced=True,
help="Number of seconds to wait before speculating a second request for a slow process. "
" see `--process-execution-speculation-strategy`",
removal_version="2.4.0.dev0",
removal_hint=(
"This option now no-ops, as speculation has been removed. It will be "
"re-implemented in the future."
),
)
register(
"--process-execution-speculation-strategy",
choices=["remote_first", "local_first", "none"],
default="none",
help="Speculate a second request for an underlying process if the first one does not complete within "
"`--process-execution-speculation-delay` seconds.\n"
"`local_first` (default): Try to run the process locally first, "
"and fall back to remote execution if available.\n"
"`remote_first`: Run the process on the remote execution backend if available, "
"and fall back to the local host if remote calls take longer than the speculation timeout.\n"
"`none`: Do not speculate about long running processes.",
advanced=True,
removal_version="2.4.0.dev0",
removal_hint=(
"This option now no-ops, as speculation has been removed. It will be "
"re-implemented in the future."
),
)
register(
"--process-execution-local-enable-nailgun",
type=bool,
Expand Down