Deprecate --python-setup-resolver-version option. #11611
Conversation
Switch the default --python-setup-resolver-version to the pip-2020-resolver and update warnings for removal of the option in 2.5. [ci skip-rust] [ci skip-build-wheels]
| " for more information on the new resolver." | ||
| ), | ||
| ) | ||
| if not self.options.is_default("resolver_version"): |
There was a problem hiding this comment.
This is okay, but it's much better imo to use the official help mechanism for deprecations because it will eagerly warn on a simple ./pants --version, whereas this setup only warns when the codepath is used.
There was a problem hiding this comment.
But if the codepath is unused ... then the warning is noise right?
There was a problem hiding this comment.
Nope, the warning is solely if you manually configured the option. It doesn't display if you use the default.
There was a problem hiding this comment.
Another reason to use the help system mechanism, it will show up as deprecated in ./pants help-advanced and on the docsite.
There was a problem hiding this comment.
Done.
Were you aware the help system does not wrap deprecations like it does everything else? I can file an issue or fix.
There was a problem hiding this comment.
Yeah I realized last week, but didn't file a ticket. That'd be helpful if you have the time
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Switch the default --python-setup-resolver-version to the pip-2020-resolver
and update warnings for removal of the option in 2.5.
[ci skip-rust]
[ci skip-build-wheels]