Add Python tool support for console scripts. #11620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `MainSpecification` which can either be an `EntryPoint` or a `ConsoleScript`. Both `PexRequest` and `PexFromTargetsRequest` are updated to take a `MainSpecification` as is `PythonToolBase`. All internal rules are updated to use `ConsoleScript` where possible for improved stability of entry points across requirement upgrades. Fixes pantsbuild#11583 [ci skip-rust] [ci skip-build-wheels]
|
The main change is here in |
stuhood
approved these changes
Mar 2, 2021
Eric-Arellano
approved these changes
Mar 2, 2021
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
MainSpecificationwhich can either be anEntryPointora
ConsoleScript. BothPexRequestandPexFromTargetsRequestareupdated to take a
MainSpecificationas isPythonToolBase. Allinternal rules are updated to use
ConsoleScriptwhere possible forimproved stability of entry points across requirement upgrades.
Fixes #11583
[ci skip-rust]
[ci skip-build-wheels]