Warn when depending on files
targets in a pex_binary
or python_awslambda
#11659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our most common reported gotchas is confusion why
files
targets are not showing up withpex_binary
. #11551 attempted to fix this by simply including the files, but it turned out much more complex than I expected, including:unzip
orvenv
mode (not the default), and__file__
to anchor the relpath, which behaves differently between./pants package
and./pants run
.While we may still want to allow including
files
if we can address the above, this improves the status quo. It corresponds with new docs warnings:Example warning:
[ci skip-rust]