Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send anonymous telemetry to bugout #11697

Merged
merged 5 commits into from Mar 19, 2021
Merged

Send anonymous telemetry to bugout #11697

merged 5 commits into from Mar 19, 2021

Conversation

benjyw
Copy link
Sponsor Contributor

@benjyw benjyw commented Mar 15, 2021

Uses the humbug library to send anonymized telemetry data
to bugout. Telemetry data helps us develop and improve Pants
by detecting bugs, analyzing usage patterns and growth, etc.

Repos must opt in to telemetry. We log a warning if a repo has
not opted in or out.

See https://www.pantsbuild.org/v2.4/docs/anonymous-telemetry
and the code itself for more info on the data we send and how we
preserve anonymity and prevent leakage of proprietary information.

[ci skip-rust]

[ci skip-build-wheels]

Uses the `humbug` library to send anonymized telemetry data
to bugout.

Repos must opt in to telemetry. We log a warning if a repo has
not opted in or out.

See the code and also https://www.pantsbuild.org/v2.4/docs/anonymous-telemetry
for more info on the data we send and how we preserve anonymity
and prevent leakage of proprietary information.

[ci skip-rust]

[ci skip-build-wheels]
@benjyw benjyw changed the title Send anonymous telemetry. Send anonymous telemetry to bugout Mar 15, 2021
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
Copy link
Member

@jsirois jsirois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave most details to others - mainly signing off on the concept.

src/python/pants/goal/anonymous_telemetry.py Outdated Show resolved Hide resolved
src/python/pants/goal/run_tracker.py Outdated Show resolved Hide resolved
[ci skip-rust]

[ci skip-build-wheels]
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

src/python/pants/goal/anonymous_telemetry.py Outdated Show resolved Hide resolved
src/python/pants/goal/anonymous_telemetry.py Show resolved Hide resolved
src/python/pants/goal/anonymous_telemetry.py Show resolved Hide resolved
src/python/pants/goal/anonymous_telemetry.py Outdated Show resolved Hide resolved
src/python/pants/goal/anonymous_telemetry.py Outdated Show resolved Hide resolved
src/python/pants/goal/anonymous_telemetry.py Show resolved Hide resolved
src/python/pants/goal/anonymous_telemetry.py Outdated Show resolved Hide resolved
src/python/pants/goal/anonymous_telemetry.py Show resolved Hide resolved
src/python/pants/goal/anonymous_telemetry.py Show resolved Hide resolved
[ci skip-rust]

[ci skip-build-wheels]
@benjyw
Copy link
Sponsor Contributor Author

benjyw commented Mar 17, 2021

I've addressed all comments and updated the docs to include data policies. PTAL.

[ci skip-rust]

[ci skip-build-wheels]
@benjyw
Copy link
Sponsor Contributor Author

benjyw commented Mar 18, 2021

Ping

@Eric-Arellano
Copy link
Contributor

Docs feedback:

  • Under What data is sent, clarify this data is for the interpreter used to run Pants itself, which does not necessarily == the interpreter used to run their own code. I think this is important: there are still some orgs using Py2, which is a security vulnerability, and they may be concerned about that being shared (even with the anonymity).
  • Under What data is sent, add # of goals run. I think we should disclose this does allow us to know how many goals are custom goals, although we do not know what those goals are.

Docs look great, thanks!

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Benjy!

src/python/pants/goal/anonymous_telemetry.py Show resolved Hide resolved
@benjyw benjyw merged commit ddd91e2 into pantsbuild:master Mar 19, 2021
@benjyw benjyw deleted the humbug2 branch March 19, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants