Invalidate all files in the graph when file watching receives a rescan event. #11734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirois
approved these changes
Mar 18, 2021
[ci skip-build-wheels]
stuhood
force-pushed
the
stuhood/rescan-on-overflow
branch
from
a5c16fa
to
1344f08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When inotify kernel buffers overflow, the
notifycrate will send a Rescan flaggedEventwhich is intended to be a signal to purge in memory state. Pants currently does not react to that flag.Solution
Invalidate all files in the graph when we receive a
Rescanflagged event.[ci skip-build-wheels]