Use append_only_caches in Pex processes. #11760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Black test hang is an issue triggered by this PR. I'll break out a fix for Black which is doing something a bit whacky specifying files, perhaps required by older versions of Black, but no longer. |
Previously we cheated and exported PEX_ROOT as the absolute path of the named caches dir + "pex_root". Since we obtained the absolute path from the local machine, this cheat was unmasked by remote execution where the absolute path of the named caches dir was different. Now we use a relative PEX_ROOT that ties in with append_only_caches. The VenvPex scripts are updated to use relative paths as well. Fixes pantsbuild#11753 # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
jsirois
added a commit
to jsirois/pants
that referenced
this pull request
Mar 21, 2021
Previously we cheated and exported PEX_ROOT as the absolute path of the named caches dir + "pex_root". Since we obtained the absolute path from the local machine, this cheat was unmasked by remote execution where the absolute path of the named caches dir was different. Now we use a relative PEX_ROOT that ties in with append_only_caches. The VenvPex scripts are updated to use relative paths as well. Fixes pantsbuild#11753 (cherry picked from commit 4210c6c) [ci skip-rust] [ci skip-build-wheels]
jsirois
added a commit
that referenced
this pull request
Mar 21, 2021
Previously we cheated and exported PEX_ROOT as the absolute path of the named caches dir + "pex_root". Since we obtained the absolute path from the local machine, this cheat was unmasked by remote execution where the absolute path of the named caches dir was different. Now we use a relative PEX_ROOT that ties in with append_only_caches. The VenvPex scripts are updated to use relative paths as well. Fixes #11753 Fixes #11742 (cherry picked from commit 4210c6c) ___ And in support of the above: Simplify Black file specification. (#11762) Black supports passing an explicit list of files and we have that. This clears the way for having the pex_root named cache symlinked into the Black Process chroot without having Black trying to recursively format everything in there. (cherry picked from commit c927cee)
Eric-Arellano
added a commit
to Eric-Arellano/pants
that referenced
this pull request
Mar 23, 2021
This reverts commit 4210c6c. [ci skip-build-wheels]
Eric-Arellano
added a commit
to Eric-Arellano/pants
that referenced
this pull request
Mar 23, 2021
This reverts commit 4210c6c. [ci skip-build-wheels]
Eric-Arellano
added a commit
to Eric-Arellano/pants
that referenced
this pull request
Mar 23, 2021
This reverts commit 4210c6c. [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
added a commit
to Eric-Arellano/pants
that referenced
this pull request
Mar 24, 2021
This reverts commit 4210c6c. [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
added a commit
to Eric-Arellano/pants
that referenced
this pull request
Mar 25, 2021
This reverts commit 4210c6c. [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
added a commit
to Eric-Arellano/pants
that referenced
this pull request
Mar 25, 2021
This reverts commit 4210c6c. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we cheated and exported PEX_ROOT as the absolute path of the
named caches dir + "pex_root". Since we obtained the absolute path from
the local machine, this cheat was unmasked by remote execution where
the absolute path of the named caches dir was different.
Now we use a relative PEX_ROOT that ties in with append_only_caches.
The VenvPex scripts are updated to use relative paths as well.
Fixes #11753
[ci skip-rust]
[ci skip-build-wheels]