Dependency inference: can disambiguate modules with multiple owners via ! ignores
#11786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ia `!` ignores [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
added a commit
that referenced
this pull request
Mar 24, 2021
…ed via an include (#11789) If a user has already chosen which target to use for a module with >1 owning targets, then we should not attempt to further infer dependencies - it would be confusing if we end up inferring a dep different than their include, resulting in two owning targets for the same module. Fixes an edge case from #11786. [ci skip-rust] [ci skip-build-wheels]
stuhood
pushed a commit
that referenced
this pull request
Mar 25, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are soon adding a warning when dependency inference fails because >1 target exports the same module. For users to silence that warning, they either must explicitly depend on one of the ambiguous modules or ignore some/all of them. Why allow ignores? A user might end up wanting to ignore all of the ambiguous modules so that the module is never included.
To be consistent, because we allow ignoring all ambiguous modules to turn off dep inference for that module, ignoring all but one of the ambiguous targets will disambiguate the inference. (In practice, we expect it to be more likely users will opt-in to the specific ambiguous target they want, rather than opting out of all but one.)
[ci skip-rust]
[ci skip-build-wheels]