Ensure that metrics are gathered during abnormal exits #11793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
force-pushed
the
stuhood/reliable-run-tracker-end
branch
from
ac19b7b
to
cf54749
Compare
[ci skip-rust] [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
stuhood
force-pushed
the
stuhood/reliable-run-tracker-end
branch
from
cf54749
to
bdb0866
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As described in #11788,
RunTracker.end_runis not called forhelp, runs with no goals, or runs that end inCtrl+C. This can prevent metrics gathering.Solution
Adjust
LocalPantsRunnerto ensure that the run is ended in theRunTrackerbefore theStreamingWorkunitHandleris torn down.Result
Fixes #11788.