Add back interpreter_constraints field to pex_binary and python_awslambda
#11979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…11977) This should not have been deprecated in 2.2.x - that was a mistake. Even though `pex_binary` no longer has a `sources` field, it is still sensible to want to change the interpreter constraints for a binary. For example, it is totally valid to have a `pex_binary` with no first party code and only 3rd party reqs, and to want to set the constraints for that. [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
changed the title
interpreter_constraints field to pex_binary (Cherry-pick of #11977)interpreter_constraints field to pex_binary and python_awslambda
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
|
This is no longer a cherry-pick - I realized I needed to add back |
tdyas
approved these changes
Apr 29, 2021
tdyas
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci skip-rust]