Make python-setup resolve_all_constraints a bool. #11985
Conversation
The subset resolve feature now allows resolve_all_constraints to be a simple on/off choice indicating whether the constraints file serves as a lock file role or not. Map the existing enum to a bool and deprecate the enum values. [ci skip-rust] [ci skip-build-wheels]
|
Take this as a bit of a straw man. The resulting option provides the least user disruption - no deprecating an existing option and adding a new one with a name compromise, just deprecating enum values in favor of bool values. The treatment applied to option parsing to support this is ad-hoc in that it only works for bools. We're really not handling type functions well or uniformly and that should probably be addressed wholistically, but this is a straw man / experiment. |
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com> # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
jsirois
force-pushed
the
resolve_all_constraints/deprecate_modes
branch
from
fa56a80
to
7c946da
Compare
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
|
Using your words. As is usual, I'm not a fan since they lie a bit and you really need a book for this stuff. Yes, fewer resolves, but they could be honking big and slow down most resolves if your constraints change frequently due to 1 big - say ML app, but most apps are small and use ~no 3rdparty. |
The subset resolve feature now allows resolve_all_constraints to be a
simple on/off choice indicating whether the constraints file serves as
a lock file role or not. Map the existing enum to a bool and deprecate
the enum values.
[ci skip-rust]
[ci skip-build-wheels]