Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for global coverage reports. #12080

Merged
merged 1 commit into from May 14, 2021
Merged

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented May 14, 2021

Add --coverage-py-global-report that causes all Python coverage
reports generated by Pants to include coverage for all Python files in
all registered source roots.

Closes #12078

[ci skip-build-wheels]
[ci skip-rust]

Add `--coverage-py-global-report` that causes all Python coverage
reports generated by Pants to include coverage for all Python files in
all registered source roots.

Closes pantsbuild#12078

[ci skip-build-wheels]

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me so happy to see implemented :D Thanks John!!

I like the modeling of this being an option.

@jsirois jsirois merged commit 487c466 into pantsbuild:main May 14, 2021
@jsirois jsirois deleted the issues/12078 branch May 14, 2021 22:12
jsirois added a commit to jsirois/pants that referenced this pull request May 19, 2021
Add `--coverage-py-global-report` that causes all Python coverage
reports generated by Pants to include coverage for all Python files in
all registered source roots.

Closes pantsbuild#12078

(cherry picked from commit 487c466)

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
Eric-Arellano pushed a commit that referenced this pull request May 19, 2021
)

Add `--coverage-py-global-report` that causes all Python coverage
reports generated by Pants to include coverage for all Python files in
all registered source roots.

Closes #12078

(cherry picked from commit 487c466)

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for collecting global test coverage.
3 participants