Replace ProcessCacheScope.PER_RESTART with ProcessCacheScope.PER_RESTART_ALWAYS and ProcessCacheScope.PER_RESTART_SUCCESSFUL
#12094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ESTART_ALWAYS` and `ProcessCacheScope.PER_RESTART_SUCCESSFUL` # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
commented
May 20, 2021
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Merged
Mentioned elsewhere, but this should not be the case (except during initialization). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
ProcessCacheScope.PER_RESTARTalways memoized failures (but not cached to disk).That wasn't a problem in pantsbuild/pants because we always use
await Get(ProcessResult, Process)instead ofGet(FallibleProcessResult, Process), and the error restarts Pantsd.But, it's valid to use a fallible process result and not want to memoize failures. For example, a user is writing a plugin to check if a database is alive before test runs. They must not cache this to disk because it's not safe to, but they also don't want to have to run the check every single distinct test run.
[ci skip-build-wheels]