Add [mypy].extra_type_stubs
#13180
Merged
Add [mypy].extra_type_stubs
#13180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Not sure if I should put this into the help message? It's a little weird to do because Pants 2.8 lockfile support isn't really there to begin with. |
phlax
reviewed
Oct 9, 2021
There was a problem hiding this comment.
@Eric-Arellano thanks for resolving this
visually the code looks good, but i was unable to do an editable install so wasnt able to test
thanks again
Presumably this relates to #12794 ? Type stubs would be a "compile"-time dependency? |
[ci skip-rust] [ci skip-build-wheels] # Conflicts: # src/python/pants/backend/python/typecheck/mypy/rules_integration_test.py
Eric-Arellano
added a commit
to Eric-Arellano/pants
that referenced
this pull request
Oct 11, 2021
Follows up on pantsbuild#12597. While that change was necessary as explained there, we've had feedback from two users that they want to retain the ability to specify type stubs via option rather than normal runtime dependencies. For example, one user wants to avoid an increase in `.pex` size (because one of the stubs incorrectly depends on MyPy). Ideally, we should probably re-envision third-party type stubs wholesale so that our code distinguishes between normal dependencies vs. type stubs dependencies. When running MyPy, we use type stubs. When packaging, for example, we know to leave them off. But that requires design work and time to implement. In the meantime, we can add `[mypy].extra_type_stubs`, which satisfies the different requirements: * We don't install these into the "tool PEX", which is necessary per pantsbuild#12597. * Type stubs continue to work when done as a normal requirement. These are "extra". There is one weird edge: these type stubs don't have a lockfile associated with them. Those can't use the tool lockfile because we cannot tell MyPy to point into its tool lockfile (pantsbuild#12597). It would require a lot of new infrastructure to have a dedicated lockfile for `extra_type_stubs`. So, instead, if you do care about lockfiles, you should use type stubs like normal dependencies rather than using this option. [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
added a commit
that referenced
this pull request
Oct 11, 2021
Follows up on #12597. While that change was necessary as explained there, we've had feedback from two users that they want to retain the ability to specify type stubs via option rather than normal runtime dependencies. For example, one user wants to avoid an increase in `.pex` size (because one of the stubs incorrectly depends on MyPy). Ideally, we should probably re-envision third-party type stubs wholesale so that our code distinguishes between normal dependencies vs. type stubs dependencies. When running MyPy, we use type stubs. When packaging, for example, we know to leave them off. But that requires design work and time to implement. In the meantime, we can add `[mypy].extra_type_stubs`, which satisfies the different requirements: * We don't install these into the "tool PEX", which is necessary per #12597. * Type stubs continue to work when done as a normal requirement. These are "extra". There is one weird edge: these type stubs don't have a lockfile associated with them. Those can't use the tool lockfile because we cannot tell MyPy to point into its tool lockfile (#12597). It would require a lot of new infrastructure to have a dedicated lockfile for `extra_type_stubs`. So, instead, if you do care about lockfiles, you should use type stubs like normal dependencies rather than using this option. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on #12597. While that change was necessary as explained there, we've had feedback from two users that they want to retain the ability to specify type stubs via option rather than normal runtime dependencies. For example, one user wants to avoid an increase in
.pexsize (because one of the stubs incorrectly depends on MyPy).Ideally, we should probably re-envision third-party type stubs wholesale so that our code distinguishes between normal dependencies vs. type stubs dependencies. When running MyPy, we use type stubs. When packaging, for example, we know to leave them off. But that requires design work and time to implement.
In the meantime, we can add
[mypy].extra_type_stubs, which satisfies the different requirements:[mypy].extra_requirements#12597.There is one weird edge: these type stubs don't have a lockfile associated with them. Those can't use the tool lockfile because we cannot tell MyPy to point into its tool lockfile (#12597). It would require a lot of new infrastructure to have a dedicated lockfile for
extra_type_stubs. So, instead, if you do care about lockfiles, you should use type stubs like normal dependencies rather than using this option.[ci skip-rust]
[ci skip-build-wheels]