[Trigger CI] Fold PythonTestBuilder into the PytestRun task. #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjyw
force-pushed
the
kill_test_builder
branch
from
3715e05
to
86eabc9
Compare
benjyw
force-pushed
the
kill_test_builder
branch
from
86eabc9
to
6661a00
Compare
added 2 commits
March 31, 2015 14:26
PythonTestBuilder was a vestige of the old, pre-task Pants. The PytestRun task was implemented as a thin wrapper around it. This change merges the functionality into PytestRun and gets rid of PythonTestBuilder as a standalone class. - Fixes various kludges, such as logging: Now code that was formerly in PythonTestBuilder has access to the task's logging facilities, so it can use those instead of print(). - PythonTestBuilder's test is now a task test for PytestRun. It uses the new TaskTestBase, and demonstrates how this base class could be used instead of the old PythonTaskTest in the remaining tests that still use the latter.
benjyw
force-pushed
the
kill_test_builder
branch
from
6661a00
to
a928ff7
Compare
2 similar comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PythonTestBuilder was a vestige of the old, pre-task Pants. The PytestRun
task was implemented as a thin wrapper around it. This change merges
the functionality into PytestRun and gets rid of PythonTestBuilder as
a standalone class.
in PythonTestBuilder has access to the task's logging facilities, so
it can use those instead of print().
the new TaskTestBase, and demonstrates how this base class could
be used instead of the old PythonTaskTest in the remaining tests
that still use the latter.