Fix .pyi type stubs to show up in python_distribution
#14033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
benjyw
approved these changes
Dec 30, 2021
Eric-Arellano
added a commit
to Eric-Arellano/pants
that referenced
this pull request
Dec 30, 2021
…#14033) @asherf discovered that even though we were including `.pyi` files in the chroot we give to `setuptools`, we need to set the value in `package_data` for setuptools to actually include the file. See https://blog.ian.stapletoncordas.co/2019/02/distributing-python-libraries-with-type-annotations.html. Because of this issue, `pantsbuild.pants` was not including `native_engine.pyi` in the wheel. [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
added a commit
to Eric-Arellano/pants
that referenced
this pull request
Dec 30, 2021
…#14033) @asherf discovered that even though we were including `.pyi` files in the chroot we give to `setuptools`, we need to set the value in `package_data` for setuptools to actually include the file. See https://blog.ian.stapletoncordas.co/2019/02/distributing-python-libraries-with-type-annotations.html. Because of this issue, `pantsbuild.pants` was not including `native_engine.pyi` in the wheel. [ci skip-rust] [ci skip-build-wheels]
stuhood
pushed a commit
to stuhood/pants
that referenced
this pull request
Jan 3, 2022
…#14033) @asherf discovered that even though we were including `.pyi` files in the chroot we give to `setuptools`, we need to set the value in `package_data` for setuptools to actually include the file. See https://blog.ian.stapletoncordas.co/2019/02/distributing-python-libraries-with-type-annotations.html. Because of this issue, `pantsbuild.pants` was not including `native_engine.pyi` in the wheel. [ci skip-rust] [ci skip-build-wheels]
stuhood
pushed a commit
to stuhood/pants
that referenced
this pull request
Jan 3, 2022
…#14033) @asherf discovered that even though we were including `.pyi` files in the chroot we give to `setuptools`, we need to set the value in `package_data` for setuptools to actually include the file. See https://blog.ian.stapletoncordas.co/2019/02/distributing-python-libraries-with-type-annotations.html. Because of this issue, `pantsbuild.pants` was not including `native_engine.pyi` in the wheel. [ci skip-rust] [ci skip-build-wheels]
stuhood
pushed a commit
that referenced
this pull request
Jan 3, 2022
… of #14033) (#14036) @asherf discovered that even though we were including `.pyi` files in the chroot we give to `setuptools`, we need to set the value in `package_data` for setuptools to actually include the file. See https://blog.ian.stapletoncordas.co/2019/02/distributing-python-libraries-with-type-annotations.html. Because of this issue, `pantsbuild.pants` was not including `native_engine.pyi` in the wheel. [ci skip-rust] [ci skip-build-wheels]
stuhood
pushed a commit
that referenced
this pull request
Jan 3, 2022
… of #14033) (#14035) @asherf discovered that even though we were including `.pyi` files in the chroot we give to `setuptools`, we need to set the value in `package_data` for setuptools to actually include the file. See https://blog.ian.stapletoncordas.co/2019/02/distributing-python-libraries-with-type-annotations.html. Because of this issue, `pantsbuild.pants` was not including `native_engine.pyi` in the wheel. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@asherf discovered that even though we were including
.pyifiles in the chroot we give tosetuptools, we need to set the value inpackage_datafor setuptools to actually include the file. See https://blog.ian.stapletoncordas.co/2019/02/distributing-python-libraries-with-type-annotations.html.Because of this issue,
pantsbuild.pantswas not includingnative_engine.pyiin the wheel.[ci skip-rust]
[ci skip-build-wheels]