thrift: add scrooge java backend #14043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'm not sure it makes sense to add Android without greater Android ecosystem support - what's your motivation for adding that backend? |
It generates Java and so seemed easy enough to add. But yeah, probably useless without more general Android support. Will remove. |
added 4 commits
January 8, 2022 12:35
[ci skip-rust] [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
[ci skip-rust]
tdyas
changed the title
[ci skip-rust]
tdyas
force-pushed
the
scrooge_java_and_android_backends
branch
from
3476396
to
380e48f
Compare
stuhood
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add backend for the Scrooge's Java code generation.
This backend should generate the same code as Apache Thrift does for Java (but using Scrooge's parser etc.) It should not be enabled at the same time as the Apache Thrift Java backend.