[jvm] Use appropriate coordinate serialization for Coursier CLI inputs. (cherrypick of #14038) #14046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. (pantsbuild#14038) Coursier uses a separate key/value attribute input format for CLI arguments than the format that it uses in reports (which we also use in our lockfile). We had started to use the attribute-carrying format to specify a `url` for artifacts, but it is additionally used to specify the `classifier` and `packaging`. Improves the test from pantsbuild#14010 (since although we generated a lockfile, we could not successfully fetch one of the artifacts inside of it), and should fix the failure in pantsbuild#13990. [ci skip-rust] [ci skip-build-wheels]
chrisjrn
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coursier uses a separate key/value attribute input format for CLI arguments than the format that it uses in reports (which we also use in our lockfile). We had started to use the attribute-carrying format to specify a
urlfor artifacts, but it is additionally used to specify theclassifierandpackaging.Improves the test from #14010 (since although we generated a lockfile, we could not successfully fetch one of the artifacts inside of it), and should fix the failure in #13990.
[ci skip-rust]
[ci skip-build-wheels]