Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix @rule Effect validation for not cacheable types. #14069

Merged
merged 1 commit into from Jan 4, 2022
Merged

Fix @rule Effect validation for not cacheable types. #14069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/python/pants/engine/rules.py
View file
Open in desktop
Expand Up @@ -296,8 +296,6 @@ def validate_requirements(
awaitables: Tuple[AwaitableConstraints, ...],
cacheable: bool,
) -> None:
if not cacheable:
return
# TODO: Technically this will also fire for an @_uncacheable_rule, but we don't expose those as
# part of the API, so it's OK for these errors not to mention them.
for ty in parameter_types:
Expand Down