[Docker] Fix bug when a putative target address did not exist. #14125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-rust] [ci skip-build-wheels]
|
For dep inference, it would be desirable to be able to go from a built artifact path to the target address that built it, rather than guessing, as we do now. ;) |
|
Added cherry-pick label, as I think it would be nice to have this fixed also in 2.9.x |
stuhood
approved these changes
Jan 10, 2022
|
@kaos : This doesn't quite pick cleanly, so I'll leave that for you. I had been thinking about cutting |
kaos
added a commit
to kaos/pants
that referenced
this pull request
Jan 10, 2022
…build#14125) The issue was that we attempted to translate all inferred addresses for dependencies to targets, and if they didn't exist, boom. This fix goes via all known addresses for the relevant directories, and filters the list of inferred addresses down to what is actually defined. Fixes pantsbuild#14031. [ci skip-rust] [ci skip-build-wheels]
kaos
added a commit
that referenced
this pull request
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that we attempted to translate all inferred addresses for dependencies to targets, and if they didn't exist, boom.
This fix goes via all known addresses for the relevant directories, and filters the list of inferred addresses down to what is actually defined.
Fixes #14031