Replace jvm-generate-lockfiles goal with generate-lockfiles
#14176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
commented
Jan 14, 2022
| artifact_inputs: FrozenOrderedSet[str] | ||
|
|
||
| @classmethod | ||
| def from_tool(cls, tool: JvmToolBase) -> JvmLockfileRequest: |
There was a problem hiding this comment.
Note that before we were erroring when using this method and the DEFAULT_LOCKFILE was used. That is now instead handled by generate_lockfiles.py.
Comment on lines
+27
to
+28
| class JvmLockfileRequest(LockfileRequest): | ||
| artifact_inputs: FrozenOrderedSet[str] |
There was a problem hiding this comment.
LockfileRequest already has resolve_name and lockfile_dest. So this just augments it with additional info.
Note that this generic type will be used for user lockfiles, too. I haven't yet started merging those.
Comment on lines
+44
to
+47
| @rule(desc="Generate JVM lockfile", level=LogLevel.DEBUG) | ||
| async def generate_jvm_lockfile( | ||
| request: JvmLockfileRequest, | ||
| ) -> Lockfile: |
There was a problem hiding this comment.
Same as before, minus the types changing.
Comment on lines
+59
to
+62
| @rule | ||
| async def load_jvm_lockfile( | ||
| request: JvmLockfileRequest, | ||
| ) -> CoursierResolvedLockfile: |
There was a problem hiding this comment.
Same as before, only the types changed.
stuhood
approved these changes
Jan 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have a consistent mechanism for tool lockfiles.
This means that Python and JVM lockfiles now share the same namespace: