Don't complain about unowned string imports #14179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejcannon
commented
Jan 15, 2022
src/python/pants/backend/python/dependency_inference/scripts/import_parser.py
Show resolved
Hide resolved
thejcannon
commented
Jan 15, 2022
src/python/pants/backend/python/dependency_inference/parse_python_imports.py
Outdated
Show resolved
Hide resolved
Eric-Arellano
approved these changes
Jan 18, 2022
src/python/pants/backend/python/dependency_inference/parse_python_imports.py
Outdated
Show resolved
Hide resolved
src/python/pants/backend/python/dependency_inference/parse_python_imports.py
Outdated
Show resolved
Hide resolved
src/python/pants/backend/python/dependency_inference/parse_python_imports_test.py
Outdated
Show resolved
Hide resolved
src/python/pants/backend/python/dependency_inference/scripts/import_parser.py
Outdated
Show resolved
Hide resolved
src/python/pants/backend/python/dependency_inference/scripts/import_parser.py
Show resolved
Hide resolved
…hon_imports.py Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
|
Updated with "strong"/"weak". Only possible improvements would be to maybe default in the tests, but I don't think I care that strongly. |
Eric-Arellano
approved these changes
Jan 18, 2022
|
Ready for me to merge after green CI? |
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title says it all!