Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename # pants: ignore to # pants: no-infer-dep #14225

Merged
merged 1 commit into from Jan 21, 2022
Merged

Rename # pants: ignore to # pants: no-infer-dep #14225

merged 1 commit into from Jan 21, 2022

Conversation

thejcannon
Copy link
Member

Brought up in #14059

@thejcannon thejcannon mentioned this pull request Jan 21, 2022
Merged
Eric-Arellano
Eric-Arellano approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Thanks!

Going to wait to merge till at least one other signs off

benjyw
benjyw approved these changes Jan 21, 2022
View reviewed changes
Copy link
Sponsor Contributor

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

kaos
kaos approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@kaos kaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍🏽
I liked "no-infer-dep" more than "ignore-dep".

@kaos kaos merged commit c184d0a into pantsbuild:main Jan 21, 2022
@thejcannon thejcannon deleted the infer-dep branch August 17, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaos kaos kaos approved these changes

@benjyw benjyw benjyw approved these changes

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

@stuhood stuhood Awaiting requested review from stuhood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thejcannon @kaos @benjyw @Eric-Arellano