Fix packaged file names for pex_binaries target generator
#14269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
requested review from
stuhood,
benjyw and
thejcannon
and removed request for
benjyw
thejcannon
approved these changes
Jan 26, 2022
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
benjyw
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13910 added the very useful
pex_binariestarget generator, but we missed that theoutput_pathwas still always using the target name to calculate the default. With generated targets, they all share the sametarget_name, so this was causing./pants package build-support/bin:to crash due to a merge conflict withMergeDigests.Now:
It also caused
./pants runto be a bit confusing, saying that it was buildingbin.pexrather thanchangelog_py.pex.We still risk crashes if the user defines two
pex_binariesover the same entry points (file names) in the same directory (i.e. sameAddress.spec_path). To truly make this robust, we need to use theAddress.spec_path,Address.target_name, andAddress.generated_name. Should we do that? It makes the result much more verbose.[ci skip-rust]
[ci skip-build-wheels]