Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pymongo can be imported #14284

Merged
merged 1 commit into from Jan 27, 2022
Merged

pymongo can be imported #14284

merged 1 commit into from Jan 27, 2022

Conversation

thejcannon
Copy link
Member

See https://pantsbuild.slack.com/archives/C046T6T9U/p1643311795359369

TL;DR import pymongo wouldn't add pymongo as a dependency 😞

benjyw
benjyw approved these changes Jan 27, 2022
View reviewed changes
Copy link
Sponsor Contributor

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Bit of a screw up in the original default mapping, I guess.

thejcannon added a commit to thejcannon/pants that referenced this pull request Jan 27, 2022
@thejcannon
pymongo can be imported (Cherry-pick of pantsbuild#14284)
c545737
@thejcannon thejcannon removed the request for review from Eric-Arellano January 27, 2022 20:31
Eric-Arellano
Eric-Arellano approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops!

@Eric-Arellano Eric-Arellano merged commit b5341a4 into pantsbuild:main Jan 27, 2022
Eric-Arellano pushed a commit that referenced this pull request Jan 27, 2022
@thejcannon
Fix bad default module mapping for PyMongo (Cherry-pick of #14284) (#…
bf3d0db 
…14285)

[ci skip-rust]
@thejcannon thejcannon deleted the pymongo branch August 17, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjyw benjyw benjyw approved these changes

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thejcannon @benjyw @Eric-Arellano