Deprecate generate-user-lockfile and [python].experimental_lockfile in favor of [python].experimental_resolves
#14288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is possible because apparently we only have one resolve # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]
…e` in favor of `[python].experimental_resolves` # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]
…al-lockfile [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that Pants only needs a single resolve. Our testprojects resolve wasn't actually used by anything. (We could always add this back for testing purposes.)
So, thanks to #14287, we can use
[python].experimental_resolvesjust like[python].experimental_lockfilewas being used: the feature currently supports a single resolve.Benefits to this change:
generate-lockfilesrather thangenerate-user-lockfiles