Fix Pylint to consider transitive third-party dependencies #14289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-build-wheels] [ci skip-rust]
|
Beyond correctness for PYlint, another motivation is to remove |
thejcannon
approved these changes
Jan 28, 2022
| @@ -222,12 +226,14 @@ def test_includes_transitive_dependencies(rule_runner: RuleRunner) -> None: | |||
| { | |||
| "BUILD": dedent( | |||
| """\ | |||
| python_requirement(name='transitive_req', requirements=['fake']) | |||
| python_requirement(name='transitive_req', requirements=['freezegun']) | |||
There was a problem hiding this comment.
hahahah credit to @asherf for teaching me about freezegun
There was a problem hiding this comment.
Oh hey, that's actually very useful. We have tests that call those functions and are currently passing only because they are cached. 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #13918, but for third-party deps. As with first-party code, Pylint doesn't complain if transitive deps are missing, but it is less exhaustive than normal.
[ci skip-build-wheels]
[ci skip-rust]