Fix executability of materialized files for non-owners #14298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-build-wheels]
stuhood
force-pushed
the
stuhood/more-executability
branch
from
b6f4a1b
to
a192341
Compare
Eric-Arellano
approved these changes
Jan 29, 2022
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Jan 29, 2022
…4298) As reported in pantsbuild#14280, pantsbuild#13857 removed the executable bit for non-owners of a file. This change restores it (and expands the test to note a subtlety of the default umask on macOS). Fixes pantsbuild#14280. # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #14280, #13857 removed the executable bit for non-owners of a file. This change restores it (and expands the test to note a subtlety of the default umask on macOS).
Fixes #14280.